Benjamin Otte [Sat, 14 Jan 2012 02:22:59 +0000 (03:22 +0100)]
styleproperty: Introduce "specified type" and "computed type"
Make the types explicit. This way, we can actually do useful stuff with
them (like sanity checks, d'oh).
Benjamin Otte [Sat, 14 Jan 2012 01:38:42 +0000 (02:38 +0100)]
css: Make the 'currentColor' keyword a symbolic color
This is the first step on a quest to ensure that there is only ever one
GType in use for GValues in every stage of the CSS resolving process.
Benjamin Otte [Wed, 1 Feb 2012 23:14:01 +0000 (00:14 +0100)]
raleigh: remove general 'padding' declaration
Fixes reftests that were broken after images and labels applied padding.
Things look much more cramped now. On the plus side, treeview headers
and comboboxes have better spacing. Menubars look like crap now though.
Needs someone with artistical talent to figure out.
Benjamin Otte [Wed, 1 Feb 2012 23:09:05 +0000 (00:09 +0100)]
raleigh: Remove unnecessary border-width declaration
Benjamin Otte [Wed, 1 Feb 2012 23:04:08 +0000 (00:04 +0100)]
raleigh: Don't set bg-color for all widgets
Just set oit for things that need it.
(FIXME: Buttons should probably not need it, but spinbuttons and
treeview headers don't have a proper background without it.)
Cosimo Cecchi [Wed, 1 Feb 2012 22:58:11 +0000 (17:58 -0500)]
reftests: set border-image: none in border-image-url's reference CSS
Fix border-image-url reftest
Cosimo Cecchi [Wed, 1 Feb 2012 22:57:45 +0000 (17:57 -0500)]
reftests: add a bunch of missing reset-to-defaults
Fix the css-match-* reftests.
Cosimo Cecchi [Wed, 1 Feb 2012 18:19:52 +0000 (13:19 -0500)]
app-chooser-dialog: cancel the PK operation when the dialog is dismissed
This doesn't really seem to have any effect; probably PK doesn't listen
for changes on the passed-in cancellable, but it's correct.
Related to: https://bugzilla.gnome.org/show_bug.cgi?id=649121
Cosimo Cecchi [Wed, 1 Feb 2012 18:16:06 +0000 (13:16 -0500)]
app-chooser-dialog: make sure to hold a ref when doing async ops
Hold a ref to the GtkDialog while doing async operations with the
GtkAppChooserOnline object.
This is needed, since somebody could call gtk_widget_destroy() on us
while an async operation is in progress. We don't want to be finalized
in that case, but mark the fact that we were dismissed and just return
from the callback in that case.
This avoids crashing if the dialog is destroyed in the middle of a PK
operation.
https://bugzilla.gnome.org/show_bug.cgi?id=649121
Benjamin Otte [Wed, 1 Feb 2012 14:44:27 +0000 (15:44 +0100)]
gtkmain: Invoke keysnoopers unconditionally
Now that ATK no longer uses a key snooper but is invoked directly,
checking in advance for existing snoopers is wrong and stops ATK from
working.
Also: code reduction without performance loss == good thing.
https://bugzilla.gnome.org/show_bug.cgi?id=669176
Cosimo Cecchi [Wed, 1 Feb 2012 01:18:09 +0000 (20:18 -0500)]
combobox: fix cell area allocation in menu mode for RTL
We were missing a padding to subtract from the child widget here.
Cosimo Cecchi [Wed, 1 Feb 2012 00:09:24 +0000 (19:09 -0500)]
combobox: fix dropdown menu alignment for RTL languages
We need to add in the left padding, instead of subtracting it in that
case.
Cosimo Cecchi [Wed, 1 Feb 2012 00:02:36 +0000 (19:02 -0500)]
combobox: use gtk_container_class_handle_border_width()
Avoids us fiddling with the border width manually in our size request
and allocation cycles.
Cosimo Cecchi [Tue, 31 Jan 2012 23:54:40 +0000 (18:54 -0500)]
combobox: always trim the allocated area by padding and border for child
When we're size allocating the children widgets, always trim the
allocation for padding and border of GtkComboBox, as that's all the area
they have available.
Cosimo Cecchi [Tue, 31 Jan 2012 23:45:09 +0000 (18:45 -0500)]
combobox: cleanup allocation of children in list mode
Instead of setting the same values for child allocation in different
places, just do it once.
Cosimo Cecchi [Tue, 31 Jan 2012 23:35:34 +0000 (18:35 -0500)]
combobox: cleanup and comment the allocation code somewhat
Cosimo Cecchi [Tue, 31 Jan 2012 23:33:37 +0000 (18:33 -0500)]
combobox: make sure to respect the GtkComboBox padding in menu mode
When the combobox is in menu mode, we still shouldn't discard the
GtkComboBox padding value; it's wrong to allocate it to the button.
Cosimo Cecchi [Tue, 31 Jan 2012 23:30:13 +0000 (18:30 -0500)]
combobox: cleanup GTK_COMBO_BOX_SIZE_ALLOCATE_BUTTON
It was using the wrong padding values for RTL, and generally, using the
same variables in a distant macro makes this method even more
complicated than it already is...
Cosimo Cecchi [Tue, 31 Jan 2012 21:03:00 +0000 (16:03 -0500)]
combobox: simplify size request code by using the button content box
Similar to what we did for size_allocate.
Cosimo Cecchi [Tue, 31 Jan 2012 20:34:00 +0000 (15:34 -0500)]
combobox: move the allocation of the button contents box directly
If we're in menu mode with no children, instead of tweaking the
allocation of the arrow and the separator separately, tweak the
allocation of the box that contain both.
Cosimo Cecchi [Tue, 31 Jan 2012 19:43:17 +0000 (14:43 -0500)]
combobox: allocate the CSS borders to GtkComboBox
Consider borders in the allocation/size-request machinery, like every
widget should do.
Cosimo Cecchi [Tue, 31 Jan 2012 17:01:53 +0000 (12:01 -0500)]
combobox: remove handling of focus-padding and focus-line-width
GtkComboBox always handles focus through its children, so there's no
need to request and allocate them again.
In fact, Adwaita was forcing these style properties to zero for
GtkComboBox.
Javier Jardón [Tue, 31 Jan 2012 19:33:25 +0000 (19:33 +0000)]
gtkentry: Fix compilation warnings
Javier Jardón [Tue, 31 Jan 2012 19:30:09 +0000 (19:30 +0000)]
gtkspinbutton: Fix compilation warning
Ryan Lortie [Tue, 31 Jan 2012 18:22:22 +0000 (13:22 -0500)]
Bring back the GMenu separators
4240bfb74abf53adb07afc4135dadde4ab866b1f contained a likely copy/paste
mishap that accidentally disabled all separators for GtkMenus created
from GMenuModels.
Bring them back.
Cosimo Cecchi [Mon, 30 Jan 2012 22:27:17 +0000 (17:27 -0500)]
entry: deprecate the progress-border style property
Since we don't use it anymore.
Cosimo Cecchi [Mon, 30 Jan 2012 22:26:05 +0000 (17:26 -0500)]
entry: use the CSS margin for the progress margin offset
The progressbar inside GtkEntry has a progress-border style property,
which is actually the margin of the progressbar inside the GtkEntry
allocation.
Use a CSS margin instead of reading the progress-border property.
Cosimo Cecchi [Mon, 30 Jan 2012 21:47:55 +0000 (16:47 -0500)]
entry: use padding on the image area to position the image
Don't assume the padding of the icons is the same padding of the rest of
the entry.
This also allows to set different paddings for left and right icons.
Cosimo Cecchi [Mon, 30 Jan 2012 21:10:05 +0000 (16:10 -0500)]
entry: deprecate inner-border and gtk_entry_get/set_inner_border()
They're unused in GTK now and have suitable replacements in the CSS
properties.
Cosimo Cecchi [Mon, 30 Jan 2012 20:25:04 +0000 (15:25 -0500)]
cell-renderer-text: don't use gtk_entry_set_inner_border()
There's no need to, since now the theme can just tweak the padding like:
.cell.entry {
padding: 12;
}
Cosimo Cecchi [Mon, 30 Jan 2012 22:52:44 +0000 (17:52 -0500)]
cell-renderer: add the CELL style class to the editing widget
When we create an editing widget, add the CELL style class to it, for
identification by the themes.
Cosimo Cecchi [Mon, 30 Jan 2012 20:23:26 +0000 (15:23 -0500)]
entry: always add padding to the allocation
Even when we don't have a frame. We just ignore the borders in this
case.
Cosimo Cecchi [Mon, 30 Jan 2012 20:04:00 +0000 (15:04 -0500)]
entry: don't consider inner-border for allocation and layout
We want to deprecate the inner-border property and use the standard CSS
border/padding properties. Start with replacing its uses in GtkEntry.
Cosimo Cecchi [Mon, 30 Jan 2012 19:05:16 +0000 (14:05 -0500)]
entry: don't blindly center the text area in the allocated height
Since top/bottom borders might be different.
Cosimo Cecchi [Mon, 30 Jan 2012 19:03:26 +0000 (14:03 -0500)]
entry: change _gtk_entry_get_borders() to return a GtkBorder
Cosimo Cecchi [Mon, 30 Jan 2012 18:59:22 +0000 (13:59 -0500)]
entry: allocate the CSS borders to GtkEntry
Every widget should allocate its borders. Make this true for GtkEntry.
Marek Kasik [Tue, 31 Jan 2012 11:15:43 +0000 (12:15 +0100)]
printing: Don't crash when printing
This commit fixes crash which occurs in Firefox, Thunderbird and Inkscape
during printing. This crash was caused because of wrong handling of Custom
CUPS options. (#543520)
Michael Meeks [Tue, 31 Jan 2012 10:36:54 +0000 (10:36 +0000)]
broadway: terminate v7 input to avoid parsing uninit memory.
Ryan Lortie [Tue, 31 Jan 2012 05:07:52 +0000 (00:07 -0500)]
GtkBuilder menus: reject all attributes on <item>
These were just being silently ignored before. That's bad, since it
used to be valid to have these.
Matthias Clasen [Tue, 31 Jan 2012 04:16:43 +0000 (23:16 -0500)]
Bump version
Matthias Clasen [Tue, 31 Jan 2012 04:15:55 +0000 (23:15 -0500)]
3.3.12
Matthias Clasen [Tue, 31 Jan 2012 03:12:32 +0000 (22:12 -0500)]
Drop some unintentional exports
Matthias Clasen [Tue, 31 Jan 2012 02:19:17 +0000 (21:19 -0500)]
Fix menu xml syntax in tests
Benjamin Otte [Tue, 31 Jan 2012 02:59:32 +0000 (03:59 +0100)]
shorthand: Only unset values that are set
Otherwise g_value_unset() complains. And that breaks the testsuite.
Benjamin Otte [Mon, 30 Jan 2012 13:41:05 +0000 (14:41 +0100)]
window: Avoid unnecessary attach-widget resets
Matthias Clasen [Tue, 31 Jan 2012 01:46:44 +0000 (20:46 -0500)]
Fix make check
Several unwanted symbols have sneaked in.
Matthias Clasen [Tue, 31 Jan 2012 01:32:22 +0000 (20:32 -0500)]
Document the gtkbuilder xml file better
Replace the (invalid) DTD in the GtkBuilder docs by a
RELAX NG schema. Also install the schema in /usr/share/gtk-3.0,
so it can be used to validate GtkBuilder ui files.
Matthias Clasen [Tue, 31 Jan 2012 00:12:27 +0000 (19:12 -0500)]
Use G_SOURCE_CONTINUE/REMOVE
Now that GLib provides these macros, we should use them
to make the code more readable.
Matthias Clasen [Mon, 30 Jan 2012 23:37:47 +0000 (18:37 -0500)]
Typo fix
Kristian Høgsberg [Mon, 30 Jan 2012 14:04:45 +0000 (09:04 -0500)]
wayland: Fix return type from gdk_wayland_window_configure()
Should be void. Copy and paste error.
Chao-Hsiung Liao [Sun, 29 Jan 2012 15:03:31 +0000 (23:03 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Kristian Høgsberg [Sun, 29 Jan 2012 12:15:12 +0000 (07:15 -0500)]
wayland: Also synthesize a configure event from gdk_window_wayland_move_resize
Matej Urbančič [Sat, 28 Jan 2012 19:42:10 +0000 (20:42 +0100)]
Updated Slovenian translation
Kjartan Maraas [Sat, 28 Jan 2012 14:44:51 +0000 (15:44 +0100)]
Updated Norwegian bokmål translation
Carlos Garcia Campos [Wed, 25 Jan 2012 18:12:18 +0000 (19:12 +0100)]
testgtk: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 18:10:47 +0000 (19:10 +0100)]
examples: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 18:09:54 +0000 (19:09 +0100)]
gtk-demo: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 18:05:25 +0000 (19:05 +0100)]
gtktreeviewcolumn: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 18:03:56 +0000 (19:03 +0100)]
gtktreeview: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:59:43 +0000 (18:59 +0100)]
gtktextview: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:55:29 +0000 (18:55 +0100)]
gtkstatusicon: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:53:56 +0000 (18:53 +0100)]
gtkspinbutton: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:51:12 +0000 (18:51 +0100)]
gtkrange: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:44:55 +0000 (18:44 +0100)]
gtkpathbar: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:41:30 +0000 (18:41 +0100)]
gtkpaned: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:40:32 +0000 (18:40 +0100)]
gtknotebook: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:38:50 +0000 (18:38 +0100)]
gtkmenutoolbutton: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:36:12 +0000 (18:36 +0100)]
gtkmenu: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:34:11 +0000 (18:34 +0100)]
gtklabel: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:32:55 +0000 (18:32 +0100)]
gtkiconview: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:31:32 +0000 (18:31 +0100)]
gtkhsv: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:29:30 +0000 (18:29 +0100)]
gtkexpander: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:28:36 +0000 (18:28 +0100)]
gtkentry: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:26:04 +0000 (18:26 +0100)]
gtkdnd: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:24:02 +0000 (18:24 +0100)]
gtkcombobox: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:21:50 +0000 (18:21 +0100)]
gtkcolorsel: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:20:23 +0000 (18:20 +0100)]
gtkcellarea: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:19:40 +0000 (18:19 +0100)]
gtkcalendar: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:18:07 +0000 (18:18 +0100)]
gtkbutton: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:16:23 +0000 (18:16 +0100)]
gtkappchooserwidget: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:15:01 +0000 (18:15 +0100)]
gtkaboutdialog: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 17:10:48 +0000 (18:10 +0100)]
gdkevents: Use symbolic names for button numbers
Carlos Garcia Campos [Wed, 25 Jan 2012 14:28:14 +0000 (15:28 +0100)]
gdk: Add macros for left, middle and right buttons
https://bugzilla.gnome.org/show_bug.cgi?id=668688
Daniel Mustieles [Thu, 26 Jan 2012 16:14:25 +0000 (17:14 +0100)]
Updated Spanish translation
Piotr Drąg [Thu, 26 Jan 2012 14:22:19 +0000 (15:22 +0100)]
Updated POTFILES.in
Piotr Drąg [Thu, 26 Jan 2012 14:22:01 +0000 (15:22 +0100)]
Updated POTFILES.in
Marek Kasik [Thu, 26 Jan 2012 09:52:47 +0000 (10:52 +0100)]
printing: Fix a typo
Fix a typo which crashes on my printer.
Michael Natterer [Thu, 26 Jan 2012 09:37:12 +0000 (10:37 +0100)]
quartz: s/gdk_cursor_ref/g_object_ref/
Michael Natterer [Thu, 26 Jan 2012 09:11:17 +0000 (10:11 +0100)]
Bug 667691 - implement gdk_window_restack() for Quartz
Apply patch from Paul Davis which implements this missing function.
(cherry picked from commit
e1c107a094f46d93f7b9bfeb029cf30ecfbedc12)
Will Newton [Thu, 12 Jan 2012 11:14:02 +0000 (11:14 +0000)]
iconcache: Always check return value of find_image_offset.
find_image_offset returns 0 if it failed to find a matching image.
Check this return value in _gtk_icon_cache_get_icon to avoid
making bad memory accesses later.
Signed-off-by: Will Newton <will.newton@imgtec.com>
https://bugzilla.gnome.org/show_bug.cgi?id=667745
Matthias Clasen [Thu, 26 Jan 2012 02:13:34 +0000 (21:13 -0500)]
GtkMenu: Improve annotations
Add a 'Rename to' annotation so gtk_menu_popup_for_device
appears in bindings as gtk_menu_popup (which we skip anyway).
https://bugzilla.gnome.org/show_bug.cgi?id=657385
Matthias Clasen [Thu, 26 Jan 2012 01:58:55 +0000 (20:58 -0500)]
Add some menu markup documentation
Ryan Lortie [Thu, 26 Jan 2012 01:56:06 +0000 (20:56 -0500)]
Remove one last user of gmenumarkup
Ryan Lortie [Wed, 25 Jan 2012 16:30:11 +0000 (11:30 -0500)]
GtkTimeline: protect the timeline from unref
The timeline frame function emits several signals, assuming that the
timeline will exist after these signals return. This assumption can be
invalid if signal handlers unref the timeline.
https://bugzilla.gnome.org/show_bug.cgi?id=668675
Ryan Lortie [Wed, 25 Jan 2012 23:23:25 +0000 (18:23 -0500)]
GtkBuilder: change format of menus
Change the format of GtkBuilder <menu> to be more in-line with the style
of the rest of GtkBuilder so that we can do translation in a consistent
way.
The format is now substantially more difficult to hand-write, but tools
should be along soon.
There is an xslt program attached to the bug to help you convert your
existing .ui files from the old format to the new one.
https://bugzilla.gnome.org/show_bug.cgi?id=668696
Cosimo Cecchi [Wed, 25 Jan 2012 23:30:48 +0000 (18:30 -0500)]
application: sync clipboard and recent manager on shutdown
This mimics the code for gtk_main(), since GApplication iterates the
main context directly.
Matthias Clasen [Wed, 25 Jan 2012 23:21:47 +0000 (18:21 -0500)]
GtkAboutDialog: Make credits section extensible
This commit adds API that allows to add new named sections
to the Credits part of GtkAboutDialog, in addition to the
hardcoded sections for authors, documenters, artists and
translators.
https://bugzilla.gnome.org/show_bug.cgi?id=484693
Dieter Verfaillie [Wed, 25 Jan 2012 12:02:21 +0000 (13:02 +0100)]
win32: fix gdk_win32_window_raise
When calling gtk_window_present(), gdk_win32_window_raise did not
actually raise the window anymore. Replacing BringWindowToTop() with
SetForegroundWindow() fixes this.
During testing, we also discovered that sometimes SetForeGroundWindow()
will (correctly) refuse to raise the window and fail(for example: sometimes
when dragging a different application at the time of a gtk_window_present()
call). To prevent a GdkWarning from being produced, usage of the API_CALL
macro has been removed for this case.
Additional goodies of SetForeGroundWindow:
- it brings the window to the front when the process owning the
window to raise is the foreground process (for example when
gtk_window_present is called from a GtkStatusIcon's activate
signal handler)
- it limits itself to flashing the task bar button associated
with the window if the process owning the window to raise
is *not* the foreground process (for example when gtk_window_present
is called from a g_timeout_add callback function)
https://bugzilla.gnome.org/show_bug.cgi?id=665760
Benjamin Otte [Wed, 25 Jan 2012 17:28:26 +0000 (18:28 +0100)]
css: Return GArrays from shorthand parsing
GValueArray is deprecated now.
Benjamin Otte [Wed, 25 Jan 2012 17:26:56 +0000 (18:26 +0100)]
css: Use GArray in GtkCssComputedValues
GValueArray is deprecated in glib. Also, bump the required glib version
for g_array_set_clear_func().